London | 26-ITP-May | Bisrat Tesfay | Sprint 2 | Coursework - #1289
Open
B3-Bisrat wants to merge 4 commits into
Open
London | 26-ITP-May | Bisrat Tesfay | Sprint 2 | Coursework#1289B3-Bisrat wants to merge 4 commits into
B3-Bisrat wants to merge 4 commits into
Conversation
B3-Bisrat
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Jul 28, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Great effort overall, minor changes required.
| @@ -1,5 +1,5 @@ | |||
| // Predict and explain first... | |||
|
|
|||
| // I think we can not use for ... of loop for objects. Object is not iriterable. | |||
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
Thanks for the comment
We cannot use for...of directly on a plain object because objects are not iterable.
We can use for...of with Object.values(), Object.keys(), or Object.entries().
We can also use for...in directly.
| @@ -1,3 +1,3 @@ | |||
| function parseQueryString(queryString) { | |||
| const queryParams = {}; | |||
| if (queryString.length === 0) { | |||
There was a problem hiding this comment.
What happens If I pass null to the function?
Author
There was a problem hiding this comment.
Thanks for pointing that out, I hadn't considered null as an input. I'll update the function to handle invalid inputs safely and add a test for that case.
hey-hammad
added
Reviewed
B3-Bisrat
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have done all the tasks.
Questions